Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
humility diagnose
command contains its own code for looking up the task table. This code only uses theTASK_TABLE_BASE
symbol used by older kernels, and does not look for theTASK_TABLE_SPACE
symbol used by newer kernels. This means that on a recent kernel, thediagnose
command will fail:This commit changes
humility diagnose
to use theHubrisArchive::task_table
method to look up the task table, instead. Unlike the previous code, this method will look for both theTASK_TABLE_BASE
andTASK_TABLE_SIZE
symbols of older kernels, and theTASK_TABLE_SPACE
symbol of newer kernels. Now, it works for my recent Hubris build:Fixes #483